Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

[version bump] 1.6.0 #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

suyashcjoshi
Copy link

Updated PyTorch Android and TorchVision dependency vision to 1.6.0 that fixed the runtime error for this HelloWorldApp regarding the model version.

Updated PyTorch Android and TorchVision dependency vision to 1.6.0 that fixed the runtime error for this example regarding the model version.
@suyashcjoshi
Copy link
Author

This PR fixes this bug : #79

@jeremiahschung
Copy link

This happens because trace_model.py builds/saves a new version of model.pt with the torch library that's installed locally. Hence if you have PyTorch 1.6 installed, the model file would have been built with 1.6 and cannot be loaded with 1.4.

If you pull the code from the repo again (so that model.pt is also pulled) and directly run the app, it should work.

This solution works, but we'll need to update it every time a new version of PyTorch is released. A preferred fix would be to update the documentation (https://github.com/pytorch/android-demo-app/blob/master/README.md) to include an explanation to update the android PyTorch dependency version to match your local PyTorch version.

@facebook-github-bot
Copy link

Hi @SuyashJoshi!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants