each PipelineStage holds multiple submods #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fduwjj
reviewed
Aug 8, 2023
pippy/PipelineStage.py
Outdated
| self.name, self.submod = named_children[rank] | ||
| self.name, self.submod = named_children[ | ||
| rank * self.inner_depth | ||
| ] # submod = first inner node of each rank |
There was a problem hiding this comment.
nit: can we move the comment to L91?
fduwjj
reviewed
Aug 8, 2023
pippy/PipelineStage.py
Outdated
| @@ -96,6 +113,14 @@ def __init__( | |||
| if not found_node: | |||
| raise AssertionError(f"Cannot find {self.name} in graph") | |||
|
|
|||
| if self.inner_depth > 1: | |||
There was a problem hiding this comment.
nit: maybe adding some comments?
fduwjj
reviewed
Aug 8, 2023
pippy/PipelineStage.py
Outdated
| @@ -112,10 +137,27 @@ def __init__( | |||
| f"Cannot find backward for {self.name} in graph" | |||
| ) | |||
|
|
|||
| if self.inner_depth > 1: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if inner_depth > 1, each PipelineStage holds multiple submods
Fixes #(issue)
Feature/Issue validation/testing
No error occurs when internal depth == 1 (default case)
Checklist: