Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require explicit override for plugin-generated methods #17370

Conversation

sterliakov
Copy link
Contributor

Closes #17224.

Ensure that explicit-override error is never applied to functions which are not present in source code (generated by plugin), because there is no place to apply override.

@sterliakov
Copy link
Contributor Author

I hope that tox internal failure is not caused by my interference...

This comment has been minimized.

@sterliakov
Copy link
Contributor Author

sterliakov commented Jun 12, 2024

It's transitive filelock dependency upgrade: current CI fails with 3.15.0, but succeeds with 3.14.0. I was able to reproduce this problem locally, pinning to filelock != 3.15.0 resolves the tox run problem. Would it be appropriate to add such a pin to this pull request (that breaks the "one change per PR" rule, but probably "internal dependency pin in CI" isn't that important)? Should I submit it separately (or probably investigate deeper)? Probably nothing, filelock maintainers are already engaged and work on this.

@sterliakov
Copy link
Contributor Author

Cross-ref: tox-dev/filelock#337

@AlexWaygood AlexWaygood reopened this Jun 12, 2024
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants