-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Distribution.origin
reflecting content of direct_url.json.
#465
Conversation
Any blockers on this? Would be nice to have. |
36c9917
to
1750ceb
Compare
diffcov is reporting this failure:
|
That doesn't even make sense. One of those lines is blank and the other is the beginning of a docstring (executed unconditionally). importlib_metadata/importlib_metadata/__init__.py Lines 632 to 635 in 1750ceb
Wait, what? I did just rewrite two commits to remove the unintentionally added other files ("out.txt" and "before.mtree"), but I didn't touch
At least those lines correspond to the lines changed in this diff :). |
I don't understand how the lines aren't covered, given the test specifically exercises the |
Oh, maybe the issue is the test isn't derived from |
Yep. That was it... and demonstrates that the test is not in fact capturing the expectation. Hooray for diffcov for catching an otherwise missed expectation. |
1750ceb
to
9c2b0b4
Compare
9c2b0b4
to
f480907
Compare
funny i don't remember what i wanted this for but thanks! |
Partial implementation of #404.