Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) #94608

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 6, 2022

…ncioTestCase (pythonGH-94593)

(cherry picked from commit 14fea6b)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 6 of 9 required status checks are expected..

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303
Copy link
Contributor

The title has a typo, would be nice to fix it. (I cannot edit).

@pablogsal pablogsal changed the title [3.11] GH-93896: AAlways set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) [3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) Jul 6, 2022
@pablogsal
Copy link
Member

Done 👍

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants