GH-115869: Make jit_stencils.h reproducible
#127166
Open
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
build
brandtbucher
commented
Nov 22, 2024
| @@ -202,7 +202,8 @@ def pad(self, alignment: int) -> None: | |||
| """Pad the stencil to the given alignment.""" | |||
| offset = len(self.body) | |||
| padding = -offset % alignment | |||
| self.disassembly.append(f"{offset:x}: {' '.join(['00'] * padding)}") | |||
| if padding: | |||
There was a problem hiding this comment.
This is an unrelated cleanup.
mdboom
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the core dev sprint, we discussed the possibility of hosting pre-built
jit_stencils.hfiles for common platforms and build configurations.While there's a lot of work involved in making that happen (I'll post a rough plan shortly), this is the first logical step in that direction. This PR replaces absolute file paths in the generated code with relative ones, and processes stencils in sorted order.
jit_stencils.h#115869