Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sniffio #572

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jul 28, 2018

See https://github.com/python-trio/sniffio

And also vxgmichel/aiostream#17

This shouldn't be merged (and tests will fail) until sniffio is
released on PyPI. But it demonstrates how to do it (and the tests pass
locally with my current sniffio checkout).

@njsmith
Copy link
Member Author

njsmith commented Aug 1, 2018

Okay, sniffio is now up on pypi, so this should be ready to review/merge in a few minutes when the tests are finished...

@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   99.27%   99.27%   +<.01%     
==========================================
  Files          89       89              
  Lines       10617    10651      +34     
  Branches      747      746       -1     
==========================================
+ Hits        10540    10574      +34     
  Misses         59       59              
  Partials       18       18
Impacted Files Coverage Δ
trio/_core/tests/test_run.py 100% <100%> (ø) ⬆️
trio/_core/_run.py 100% <100%> (ø) ⬆️
trio/_sync.py 100% <0%> (ø) ⬆️
trio/_ssl.py 100% <0%> (ø) ⬆️
trio/_socket.py 100% <0%> (ø) ⬆️
trio/tests/test_socket.py 100% <0%> (ø) ⬆️
trio/tests/test_sync.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b4e58...211f6c1. Read the comment docs.

@pquentin pquentin merged commit 3a942b6 into python-trio:master Aug 1, 2018
@njsmith njsmith deleted the support-sniffio branch August 1, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants