Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolve version from pip #83

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

caffeine-addictt
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

  • Make version resolve with importlib
  • This makes it unnecessary to manually update the version number in init.py

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have incremented the version according to semantic versioning.
  • I have updated the changelog accordingly.

@caffeine-addictt caffeine-addictt added the Type: Enhancement Suggest an improvement for an existing feature. label May 25, 2024
@caffeine-addictt caffeine-addictt self-assigned this May 25, 2024
@github-actions github-actions bot added Type: Test A problem or enhancement related to a test. Documentation An issue/change with the documentation. Scope: Core labels May 25, 2024
@caffeine-addictt caffeine-addictt merged commit 9919a22 into main May 25, 2024
30 checks passed
@caffeine-addictt caffeine-addictt deleted the resolve-version-from-pip branch May 25, 2024 10:44
@caffeine-addictt caffeine-addictt removed the Documentation An issue/change with the documentation. label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Suggest an improvement for an existing feature. Type: Test A problem or enhancement related to a test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant