vcs: fix parsing of basic auth http(s) credentials #791
+65
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
reviewed
Nov 22, 2024
|
How does this work with #536? Is it a replacement for that PR? |
|
Closes: #536 |
radoering
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry today does not correctly handle
poetry add 'git+https://username:[email protected]/user/repo.git'. While we do not recommend sensitive values to be persisted inpyptoject.toml,poetry.lockor in any other locations, this is the case today when the values are manually put in thepyproject.toml.Eventually, we need to figure out a way to parse the credentials and store it into the password manager and not persist it in any files that are distributed. That is largely a change in Poetry and not in core. However, there are aspects of this that should be handled here. I will follow up with another PR to handle env var credentials as specified in PEP610.
I have also removed some unused code.
Closes: #536