sdist: make clean_tar_info a classmethod again because it is used as such for generating PyPI fixtures downstream
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s such for generating PyPI fixtures downstream
|
I'd rather see that being fixed in the fixture generator since it's only importing the builder for that method (which is weird if you ask me). I made a fix here, but it turned out to be meaningless PR. |
So copy & paste? |
Either that or pull that method into an util function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the reason for
clean_tar_infobeing aclassmethod(cf #766 (comment)):https://github.com/python-poetry/poetry/blob/dcd5ae1f67abb9ed49a0e7b89235b6f3c4e30661/tests/repositories/fixtures/pypi.org/generate.py#L360