Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate develop option and rename to editable #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0scarB
Copy link

@0scarB 0scarB commented Oct 25, 2020

Resolves: python-poetry#3004

Renames develop directory and VCS dependency property to editable and raises deprecation warnings for develop.

Changes Required

  • Update specification schema in poetry-core.
  • [ ] Update dependency instances to reference editable and fallback to develop if not present. (solved by next point)
  • Update Factory.poetry_create function to check for editable and fallback to develop if not present.
  • Add deprecation warning when accessing Dependency.develop.
  • Add poetry check warning to inform users about the change.

@0scarB 0scarB force-pushed the rename-develop-option-to-editable branch from 19a5b69 to 8c0f801 Compare October 25, 2020 22:16
@0scarB 0scarB marked this pull request as ready for review October 25, 2020 22:20
@0scarB 0scarB changed the title Deprecated develop option and rename to editable Deprecate develop option and rename to editable Oct 25, 2020
@0scarB 0scarB force-pushed the rename-develop-option-to-editable branch 5 times, most recently from 8e27b56 to 82f30d4 Compare October 26, 2020 00:48
@0scarB 0scarB force-pushed the rename-develop-option-to-editable branch from 82f30d4 to 8231c07 Compare October 26, 2020 07:29
@finswimmer finswimmer requested a review from a team October 30, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant