Handle escaping % character in query #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shounakmk219
commented
Mar 14, 2024
pinotdb/db.py
Outdated
|
|
||
|
|
||
| def escape_operation(value: str) -> str: | ||
| return value.replace('%', '%%').replace('%(', '(') |
There was a problem hiding this comment.
One concern I have is what if users are already handling this escaping while sending the query. Should we handle that with return value.replace('%%', '%')replace('%', '%%').replace('%(', '(') ?
There was a problem hiding this comment.
in that case maybe you can do
value.replace('%%', '%').replace('%', '%%').replace('%(', '(')
There was a problem hiding this comment.
Or make it a place holder, then convert it back, e.g.
import re
def convert_percent_correctly(text):
# First, temporarily replace '%%' with a placeholder to avoid modifying them
temp_placeholder = "TEMP_DOUBLE_PERCENT"
text = text.replace('%%', temp_placeholder)
# Then, convert standalone '%' to '%%'
text = re.sub(r'%(?!\()', '%%', text)
# Finally, replace the placeholder back to '%%'
text = text.replace(temp_placeholder, '%%')
return text
There was a problem hiding this comment.
That's much cleaner!
xiangfu0
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue mentioned in #10