Added support for providing a timeout option while setting up a connection #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Changed the default behaviour to not have any timeout if the option is not provided.
aishikbh
changed the title
snleee
approved these changes
Nov 15, 2023
|
can we add some tests? there's no need to validate the query result but better to validate that the timeout actually is in effect
|
I have added the tests. |
walterddr
reviewed
Nov 16, 2023
walterddr
reviewed
Nov 16, 2023
walterddr
reviewed
Nov 16, 2023
Comment on lines
+36
to
+37
| with pytest.raises(httpx.ReadTimeout): | ||
| curs.execute(sql) |
There was a problem hiding this comment.
i am not very familiar with pytest, this is try to catch and expected httpx.ReadTimeout and will fail the test when timeout is not thrown correct?
There was a problem hiding this comment.
yes, that is correct
walterddr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for adding a timeout option (in seconds) while setting up a connection. If no timeout is provided, the default behaviour is to have no timeouts.