Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix httpx timeout issue #105

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix httpx timeout issue #105

merged 1 commit into from
Jul 13, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jul 13, 2024

Below are the results for python3 examples/pinot_quickstart_timeout.py

Sending SQL to Pinot: SELECT * FROM airlineStats LIMIT 5
Sending SQL to Pinot: SELECT count(*) FROM airlineStats LIMIT 5
Sending SQL to Pinot: SELECT AirlineID, sum(Cancelled) FROM airlineStats WHERE Year > 2010 GROUP BY AirlineID LIMIT 5

It was

Sending SQL to Pinot: SELECT * FROM airlineStats LIMIT 5
Sending SQL to Pinot: SELECT count(*) FROM airlineStats LIMIT 5
Sending SQL to Pinot: SELECT AirlineID, sum(Cancelled) FROM airlineStats WHERE Year > 2010 GROUP BY AirlineID LIMIT 5
Traceback (most recent call last):
  File "/Users/xiangfu/workspace/pinot-dbapi/examples/pinot_quickstart_timeout.py", line 49, in <module>
    run_main()
  File "/Users/xiangfu/workspace/pinot-dbapi/examples/pinot_quickstart_timeout.py", line 45, in run_main
    run_pinot_quickstart_timeout_example()
  File "/Users/xiangfu/workspace/pinot-dbapi/examples/pinot_quickstart_timeout.py", line 39, in run_pinot_quickstart_timeout_example
    with pytest.raises(httpx.ReadTimeout):
  File "/Users/xiangfu/anaconda3/lib/python3.11/site-packages/_pytest/python_api.py", line 986, in __exit__
    fail(self.message)
  File "/Users/xiangfu/anaconda3/lib/python3.11/site-packages/_pytest/outcomes.py", line 198, in fail
    raise Failed(msg=reason, pytrace=pytrace)
Failed: DID NOT RAISE <class 'httpx.ReadTimeout'>

@xiangfu0 xiangfu0 merged commit b0f2a4f into master Jul 13, 2024
10 checks passed
@xiangfu0 xiangfu0 deleted the fix-timeout branch July 13, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant