Add raw query response to cursor class #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Jul 4, 2024
| @@ -395,7 +396,15 @@ def finalize_query_payload( | |||
| def normalize_query_response(self, input_query, query_response): | |||
| try: | |||
| payload = query_response.json() | |||
| self.raw_query_response = { | |||
There was a problem hiding this comment.
Can you please add a test using normal query response and failure results.
As well as v1/v2 query engine.
There was a problem hiding this comment.
@xiangfu0 I have added the tests. Please review.
|
Thanks for your contribution! this should be included in the release 5.5.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now with this client, we do not have access to rich stats returned by the Pinot API as mentioned in #88
This PR will store the raw query response json returned by Pinot API. I have stored the raw json directly instead of parsing each statistic into a separate variable. This is to prevent any side effects due to future breaking changes in Pinot API.