Fix bug where equal sign could not be in value of header (#84)

python-pinot-dbapi · Nov 30, 2023 · 11482ba · 11482ba
1 parent 8b666c3
commit 11482ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pinotdb/db.py b/pinotdb/db.py
@@ -331,7 +331,7 @@ def __init__(
         extra_headers = {}
         if extra_request_headers:
             for header in extra_request_headers.split(","):
-                k, v = header.split("=")
+                k, v = header.split("=", 1)
                 extra_headers[k] = v
 
         self.session.headers.update(extra_headers)

diff --git a/tests/unit/test_db.py b/tests/unit/test_db.py
@@ -331,10 +331,11 @@ def test_instantiates_with_auth(self):
     def test_instantiates_with_extra_headers(self):
         cursor = db.Cursor(
             host='localhost', session=httpx.Client(),
-            extra_request_headers='foo=bar,baz=yo')
+            extra_request_headers='foo=bar,baz=yo,Authorization=Bearer foo=')
 
         self.assertEqual(cursor.session.headers['foo'], 'bar')
         self.assertEqual(cursor.session.headers['baz'], 'yo')
+        self.assertEqual(cursor.session.headers['Authorization'], 'Bearer foo=')
 
     def test_checks_valid_exception_if_not_containing_error_code(self):
         cursor = db.Cursor(host='localhost', session=httpx.Client())