Correctly pass DYLD_LIBRARY_PATH to delocate #8672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the benefit of reviewers - #8673 implements the |
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8671. Alternative to #8673
In #8500, I added
Pillow/pyproject.toml
Line 107 in 128f3f4
However, there is a known problem where using
DYLD_LIBRARY_PATHwith cibuildwheel doesn't propagate to delocate - https://cibuildwheel.pypa.io/en/stable/faq/#macos-passing-dyld_library_path-to-delocateThis isn't a problem in our CI job, but apparently is when running cibuildwheel locally.
This PR uses the suggested fix from cibuildwheel.