Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed giflib as webp dependency #8661

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Jan 3, 2025

Alternative to #8658

We started mentioning giflib because it is used by build_libwebp - python-pillow/pillow-wheels#98 / https://github.com/multi-build/multibuild/blob/42d761728d141d8462cd9943f4329f12fe62b155/library_builders.sh#L286-L293

However, https://developers.google.com/speed/webp/docs/compiling states

Install the libjpeg, libpng, libtiff and libgif packages, needed to convert between JPEG, PNG, TIFF, GIF and WebP image formats.

We don't ask libwebp to convert between GIF and WebP formats, so the dependency can be removed by replacing build_libwebp with a direct build_simple call.


cifuzz still appears to be failing because just runs on main - https://github.com/google/oss-fuzz/blob/master/projects/pillow/Dockerfile

If I test one of our old vulnerabilities on oss-fuzz, you can see the convert problem - https://github.com/radarhere/oss-fuzz/actions/runs/12605648048/job/35134631013#step:7:6363

But once I switch to this branch, it goes away - https://github.com/radarhere/oss-fuzz/actions/runs/12605660381

@radarhere radarhere added the WebP label Jan 4, 2025
@hugovk hugovk merged commit 2486361 into python-pillow:main Jan 4, 2025
25 checks passed
@radarhere radarhere deleted the no_giflib branch January 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants