Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace .ext. with _ #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kigawas
Copy link

@kigawas kigawas commented Aug 28, 2020

gino.ext.starlette should be replaced since lint tools work poorly with it

image

@fantix
Copy link
Member

fantix commented Sep 7, 2020

Oh, for the linter/typing to work nicely, pls consider running:

$ python -m gino.ext stub

Refs python-gino/gino#674.

@kigawas
Copy link
Author

kigawas commented Sep 8, 2020

I remember the days I was using Flask.

At that time, the extensions were named like flask.ext.sqlalchemy to mitigate the pain of package transitions but finally it got deprecated and removed.

Do we still need an ext stuff in 2020? We have lots of package management tools like poetry or flit, it won't be a pain for users to update the package, even gino_starlette becomes like starlette_gino or something else.

@wwwjfy wwwjfy force-pushed the master branch 2 times, most recently from ed4253c to f7e6516 Compare November 11, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants