Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warning about missing default fixture loop scope in tests #923

Merged
merged 18 commits into from
Aug 25, 2024

Conversation

seifertm
Copy link
Contributor

Addresses all warnings in the pytest-asyncio test suite caused by the introduction of the_asyncio_fixture_loop_scope_ configuration option (see #871).

…guration in tests/async_fixtures/test_shared_module_fixture.py
…in tests/test_event_loop_fixture_finalizer.py.
… in tests/test_explicit_event_loop_fixture_request.py.
…in tests/test_is_async_test.py, tests/test_simple.py, and tests/test_skips.py.
@seifertm seifertm added this to the v1.0 milestone Aug 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (fb5422f) to head (45649bd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   91.30%   91.10%   -0.20%     
==========================================
  Files           2        2              
  Lines         506      506              
  Branches       98       98              
==========================================
- Hits          462      461       -1     
- Misses         26       27       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seifertm seifertm added this pull request to the merge queue Aug 25, 2024
Merged via the queue into pytest-dev:main with commit 60af27b Aug 25, 2024
17 checks passed
@seifertm seifertm deleted the set-default-fixture-loop-scope branch August 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants