Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capacitated p-median with predefined facilities #374

Merged
merged 20 commits into from
Jun 13, 2023
Merged

Conversation

rongboxu
Copy link
Collaborator

@rongboxu rongboxu commented May 26, 2023

This PR is a continuation of the AGILE 2023 project and will supersede pysal/pysal#358

@rongboxu rongboxu marked this pull request as draft May 26, 2023 05:53
@rongboxu rongboxu closed this May 26, 2023
@rongboxu rongboxu reopened this May 26, 2023
@sjsrey sjsrey marked this pull request as ready for review May 26, 2023 21:21
@sjsrey sjsrey self-requested a review May 26, 2023 21:22
@jGaboardi jGaboardi added enhancement New feature or request locate labels May 27, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #374 (96183c8) into main (936c710) will increase coverage by 0.1%.
The diff coverage is 85.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    pysal/pysal#374     +/-   ##
=======================================
+ Coverage   76.7%   76.8%   +0.1%     
=======================================
  Files         27      27             
  Lines       2479    2516     +37     
=======================================
+ Hits        1902    1933     +31     
- Misses       577     583      +6     
Impacted Files Coverage Δ
spopt/locate/base.py 94.3% <80.0%> (-2.2%) ⬇️
spopt/locate/p_median.py 98.9% <94.1%> (-1.1%) ⬇️

spopt/locate/base.py Outdated Show resolved Hide resolved
spopt/locate/base.py Outdated Show resolved Hide resolved
spopt/locate/base.py Show resolved Hide resolved
spopt/locate/p_median.py Show resolved Hide resolved
spopt/tests/data/example_subject_schools.csv Show resolved Hide resolved
import os


class TestSyntheticLocate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, small synthetic test.

@jGaboardi
Copy link
Member

jGaboardi commented Jun 9, 2023

We should also open tickets:

  • to add an example notebook demonstrating this new functionality
  • adding any references to formulations @rongboxu used (if not already in the docs)
  • anything else?

To be clear, these things are not critical to be part of this PR.

@rongboxu
Copy link
Collaborator Author

We should also open tickets:

  • to add an example notebook demonstrating this new functionality
  • adding any references to formulations @rongboxu used (if not already in the docs)
  • anything else?

To be clear, these things are not critical to be part of this PR.

Thank you for opening these!

  • About 1, I think I can do it by taking the existing notebook as an example!
  • About 2, yes, I need to add one preference, which is the book, business site selection, location analysis and GIS.

@jGaboardi
Copy link
Member

  • About 2, yes, I need to add one preference, which is the book, business site selection, location analysis and GIS.

I thought we had already had that one in our References, but it looks we had missed it. So nice catch. A bibtex entry will need to be added to references.bib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GSOC2023 locate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants