Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for cascading references in docs #309

Merged
merged 7 commits into from
Jan 8, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Nov 26, 2022

This PR

@jGaboardi jGaboardi self-assigned this Nov 26, 2022
@martinfleis
Copy link
Member

This is not really solving the cause right? Just the result. Do we know where the original issue comes from apart from versions? It may as well be a bug in sphinx that should be resolved there, not by a CSS fix here.

@jGaboardi
Copy link
Member Author

This is not really solving the cause right? Just the result. Do we know where the original issue comes from apart from versions? It may as well be a bug in sphinx that should be resolved there, not by a CSS fix here.

Correct.

@martinfleis
Copy link
Member

Okay. Then it should be reported to https://github.com/ryan-roemer/sphinx-bootstrap-theme/issues and fixed there imho. We can still make our custom patch but that should not be a long term solution.

@jGaboardi
Copy link
Member Author

Okay. Then it should be reported to https://github.com/ryan-roemer/sphinx-bootstrap-theme/issues and fixed there imho. We can still make our custom patch but that should not be a long term solution.

Yeah, you're right. I had a small reproducible example somewhere, but can't find it now. After I get that either found or created again, I will report to sphinx-bootstrap-theme and merge this for a temp fix.

@jGaboardi jGaboardi changed the title fix cascading doc references & add Python 3.11 support workaround for cascading references in docs Jan 8, 2023
@jGaboardi jGaboardi removed the CI label Jan 8, 2023
@jGaboardi jGaboardi merged commit 9a9834a into pysal:main Jan 8, 2023
@jGaboardi jGaboardi deleted the update_sphinx_css branch January 8, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants