Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the "vendor" folder and added it to .gitignore #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed the "vendor" folder and added it to .gitignore #29

wants to merge 1 commit into from

Conversation

boenrobot
Copy link
Contributor

What's with this practice of having a "vendor" dir containing a whole PEAR2 installation with dependencies anyway? Those should not be in a VCS, even if they're important for development (which those frankly aren't), but should be installed separately.

@boenrobot
Removed the "vendor" folder and added it to .gitignore;
3002b3a 
Added PEAR2_Templates_Savant as an optional dependency in package.xml;
Refreshed package.xml with "pyrus make".
@cellog
Copy link
Contributor

cellog commented Aug 1, 2014

They are (were) used when generating the Pyrus.phar
On Jul 31, 2014 4:20 PM, "Vasil Rangelov" [email protected] wrote:

What's with this practice of having a "vendor" dir containing a whole
PEAR2 installation with dependencies anyway? Those should not be in a VCS,
even if they're important for development (which those frankly aren't), but

should be installed separately.

You can merge this Pull Request by running

git pull https://github.com/boenrobot/Pyrus_Developer vendor-clean

Or view, comment on, or merge it at:

#29
Commit Summary

  • Removed the "vendor" folder and added it to .gitignore;

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#29.

@boenrobot
Copy link
Contributor Author

For Pyrus itself... sure... I can understand that to generate an installer you need to not be dependent on an installer.

But surely that's not required for a plugin such as Pyrus_Developer, or any other package, right?

@cellog
Copy link
Contributor

cellog commented Aug 1, 2014

I had not noticed this was Pyrus_Developer :) I agree with you
On Aug 1, 2014 5:22 PM, "Vasil Rangelov" [email protected] wrote:

For Pyrus itself... sure... I can understand that to generate an installer
you need to not be dependent on an installer.

But surely that's not required for a plugin such as Pyrus_Developer, or
any other package, right?

—
Reply to this email directly or view it on GitHub
#29 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boenrobot @cellog