-
-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Type hints for NN and param store #2865
base: dev
Are you sure you want to change the base?
Conversation
@fritzo What exactly are the datatypes parameters? in pyro/pyro/params/param_store.py Line 185 in 005032f
|
@kamathhrishi I believe the types are def replace_param(self, param_name: str, new_param: torch.Tensor, old_param: torch.Tensor): |
Hi @kamathhrishi no rush, just FYI we switched from travis-ci to github actions so you'll need to merge the dev branch into this for ci to pass. |
Thanks for letting me know. Not sure why Github doesn't notify here when my fork is lagging behind. Also I haven't formatted my code yet so it will continue to fail. |
@kamathhrishi is this ready for review? No rush, just don't want you blocked - if so, can you run |
@eb8680 I will come back to this in September. Till then I will close it. |
This PR continues the effort of adding type hints to the codebase as described in issue #2550. This PR will add type hints to NN and param module. Additionally, it will cover the utils script and some parts of Optim that weren't completed in the previous PR.