Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computing number of gradient evaluations example #1839

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

andyElking
Copy link
Contributor

Hi,

I made a small addition to the end of the example about Bayesian logistic regression. I hope this is what you had in mind when you asked me to make a contribution in #1838.

Best,
Andy

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fehiepsi
Copy link
Member

Could you run make format to fix the lint issue?

@andyElking
Copy link
Contributor Author

Sorry about that, I fixed the linting now.

Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks great! Thanks, @andyElking !

@fehiepsi fehiepsi merged commit 643e2ca into pyro-ppl:master Aug 5, 2024
4 checks passed
@andyElking
Copy link
Contributor Author

Great news, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants