Fixes problem with definition of image locations in mosaics #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1866 .
This generalizes the parser used to define image positions, both for adding/removing slits and for manual extractions.
Defining slits to add/remove for mosaics uses the tuple that defines the mosaic. E.g., the syntax for removing a slit is
rm_slits = (1,2,3):1500:331and the syntax for adding one isadd_slits = (1,2,3):1537:297.2:353.5. Manual extraction uses the same syntax.There's an accompanying dev-suite PR, and it would be useful to add a test that does manual extraction on a mosaic coadd.