Store license-files in licenses subfolder #4728
Open
+78
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
force-pushed
the
license-files
branch
3 times, most recently
from
b35bf9e
to
939f374
Compare
cdce8p
force-pushed
the
license-files
branch
from
939f374
to
43b8f59
Compare
cdce8p
force-pushed
the
license-files
branch
from
0bb22ba
to
c47ade2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The initial draft of PEP 639 specified that license files should be written directly to the
.dist-infofolder. This was changed in later iterations. The files should now be written to.dist-info/licensesand the root folder structure should be recreated to avoid name conflicts.Additional changes to be spec compliant:
license_filesspecifier, e.g.**/LICENSE.License-Filepath delimiter.Closes #3596
Refs #4629