Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python version for GHA (and fix spurious CI error) #4716

Merged
merged 5 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ jobs:
- platform: ubuntu-latest
python: "3.10"
distutils: stdlib
# Python 3.8, 3.9 are on macos-13 but not macos-latest (macos-14-arm64)
# https://github.com/actions/setup-python/issues/850
# https://github.com/actions/setup-python/issues/696#issuecomment-1637587760
- {python: "3.8", platform: "macos-13"}
exclude:
- {python: "3.8", platform: "macos-latest"}
runs-on: ${{ matrix.platform }}
continue-on-error: ${{ matrix.python == '3.14' }}
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pyright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:
# https://blog.jaraco.com/efficient-use-of-ci-resources/
matrix:
python:
- "3.8"
- "3.12"
- "3.9"
- "3.13"
platform:
- ubuntu-latest
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 1 addition & 1 deletion mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ disable_error_code =

# CI should test for all versions, local development gets hints for oldest supported
# But our testing setup doesn't allow passing CLI arguments, so local devs have to set this manually.
# python_version = 3.8
# python_version = 3.9

exclude = (?x)(
# Avoid scanning Python files in generated folders
Expand Down
2 changes: 1 addition & 1 deletion pyrightconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"setuptools/_distutils",
],
// Our testing setup doesn't allow passing CLI arguments, so local devs have to set this manually.
// "pythonVersion": "3.8",
// "pythonVersion": "3.9",
// For now we don't mind if mypy's `type: ignore` comments accidentally suppresses pyright issues
"enableTypeIgnoreComments": true,
"typeCheckingMode": "basic",
Expand Down
2 changes: 1 addition & 1 deletion ruff.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# include pyproject.toml for requires-python (workaround astral-sh/ruff#10299)
include = "pyproject.toml"
include = ["pyproject.toml"]

exclude = [
"**/_vendor",
Expand Down
4 changes: 4 additions & 0 deletions setuptools/tests/test_easy_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,10 @@ def test_use_correct_python_version_string(tmpdir, tmpdir_cwd, monkeypatch):
assert cmd.config_vars['py_version_nodot'] == '310'


@pytest.mark.xfail(
sys.platform == "darwin",
reason="https://github.com/pypa/setuptools/pull/4716#issuecomment-2447624418",
)
def test_editable_user_and_build_isolation(setup_context, monkeypatch, tmp_path):
"""`setup.py develop` should honor `--user` even under build isolation"""

Expand Down
Loading