Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/unify/extract shutil.rmtree callbacks (and avoid repetition) #4682

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Refactor/unify/extract shutil.rmtree callbacks (and avoid repetition) #4682

merged 7 commits into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. Extract convenience wrapper of rmtree to setuptools._shutil for reuse

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d9975c6 View commit details
    Browse the repository at this point in the history

  2. Extract common pattern to remove dir if exists to setuptools._shutil

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1678730 View commit details
    Browse the repository at this point in the history

  3. Attempt to solve typechecking problems

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b9be144 View commit details
    Browse the repository at this point in the history

  4. Ignore some lines for coverage

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6ddac39 View commit details
    Browse the repository at this point in the history

  5. Refactor usage of shutil.rmtree in other parts of setuptools

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8272bc3 View commit details
    Browse the repository at this point in the history

  6. Add docstring

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bb93502 View commit details
    Browse the repository at this point in the history

  7. Extract test for shutil.rmtree callback to its own file

    @abravalheri
    abravalheri committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    db2b206 View commit details
    Browse the repository at this point in the history