Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage config update for protocols #4464

Closed
wants to merge 3 commits into from
Closed

Test coverage config update for protocols #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e01077b
Test coverage config update for protocols
Avasam Jul 9, 2024
3e36633
Run ruff format
Avasam Jul 9, 2024
90f05f2
Merge branch 'main' into test-coverage-config-update-protocol
Avasam Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ disable_warnings =
show_missing = True
exclude_also =
# jaraco/skeleton#97
@overload
# These are taken from https://coverage.readthedocs.io/en/latest/excluding.html#advanced-exclusion
class .*\bProtocol\):
if TYPE_CHECKING:
4 changes: 2 additions & 2 deletions pkg_resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@

# Use _typeshed.importlib.LoaderProtocol once available https://github.com/python/typeshed/pull/11890
class _LoaderProtocol(Protocol):
def load_module(self, fullname: str, /) -> types.ModuleType: ...
def load_module(self, fullname: str, /) -> types.ModuleType: ... # test


class _ZipLoaderModule(Protocol):
Expand Down Expand Up @@ -415,7 +415,7 @@ def register_loader_type(


@overload
def get_provider(moduleOrReq: str) -> IResourceProvider: ...
def get_provider(moduleOrReq: str) -> IResourceProvider: ... # test
@overload
def get_provider(moduleOrReq: Requirement) -> Distribution: ...
def get_provider(moduleOrReq: str | Requirement) -> IResourceProvider | Distribution:
Expand Down
6 changes: 6 additions & 0 deletions setuptools/command/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,15 @@ def finalize_options(self):

def initialize_options(self):
"""(Required by the original :class:`setuptools.Command` interface)"""
...

def finalize_options(self):
"""(Required by the original :class:`setuptools.Command` interface)"""
...

def run(self):
"""(Required by the original :class:`setuptools.Command` interface)"""
...

def get_source_files(self) -> list[str]:
"""
Expand All @@ -99,6 +102,7 @@ def get_source_files(self) -> list[str]:
with all the files necessary to build the distribution.
All files should be strings relative to the project root directory.
"""
...

def get_outputs(self) -> list[str]:
"""
Expand All @@ -112,6 +116,7 @@ def get_outputs(self) -> list[str]:
in ``get_output_mapping()`` plus files that are generated during the build
and don't correspond to any source file already present in the project.
"""
...

def get_output_mapping(self) -> dict[str, str]:
"""
Expand All @@ -122,3 +127,4 @@ def get_output_mapping(self) -> dict[str, str]:
Destination files should be strings in the form of
``"{build_lib}/destination/file/path"``.
"""
...
Loading