Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.1: Use minimum supported Python to build zipapp #1515

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

dukecat0
Copy link
Member

@dukecat0 dukecat0 commented Aug 23, 2024

Fixes #1514

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Use minimum supported Python to build zipapp

Test plan

Tested by running

# command(s) to exercise these changes

@Gitznik
Copy link
Contributor

Gitznik commented Aug 23, 2024

We probably also need a news fragment, so we can create a fix release?

@dukecat0 dukecat0 requested a review from Gitznik August 23, 2024 08:35
Gitznik
Gitznik previously approved these changes Aug 23, 2024
@chrysle chrysle changed the title Use minimum supported Python to build zipapp 1.7.1: Use minimum supported Python to build zipapp Aug 23, 2024
@chrysle chrysle added the release-version Given to PRs that should trigger CD label Aug 23, 2024
@chrysle
Copy link
Contributor

chrysle commented Aug 23, 2024

Merging this PR will trigger a patch release. Could you render the changelog, please?

@dukecat0
Copy link
Member Author

dukecat0 commented Aug 23, 2024

It seems like Github Action has done everything for me in #1517. I will close this now.
Okay I just remember we can actually run build_changelog. 😅

@dukecat0 dukecat0 closed this Aug 23, 2024
@dukecat0 dukecat0 reopened this Aug 23, 2024
@dukecat0
Copy link
Member Author

Everything should be good to go now.

@chrysle chrysle enabled auto-merge (squash) August 23, 2024 16:36
@chrysle chrysle merged commit 4462299 into main Aug 23, 2024
11 checks passed
@chrysle chrysle deleted the dukecat0-patch-1 branch August 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version Given to PRs that should trigger CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zipapp for pipx 1.7.0 is missing tomli
3 participants