-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether pip module exists in shared lib before performing any actions #1111
Conversation
Will this actually solve the issue of post fedora upgrade with a new minor version If the file An alternate idea is to move the new the new pip module detection logic into the This solution would also work for all other commands as well such as install and upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternate idea is to move the new the new pip module detection logic into the
pipx.shared_libs._SharedLibs.is_valid
property.This solution would also work for all other commands as well such as install and upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, new merge conflicts.
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/changelog.md
Summary of changes
Check whether pip module exists in shared lib before performing any actions.
Closes #1110
Test plan
Tested by running