Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notes about conda #1581

Merged
merged 21 commits into from
Nov 24, 2024
Merged

Updated notes about conda #1581

merged 21 commits into from
Nov 24, 2024

Conversation

ChrisBarker-NOAA
Copy link
Contributor

@ChrisBarker-NOAA ChrisBarker-NOAA commented Aug 1, 2024

This is more or less, an update to: #1269, but adapted to the new structure.

However, conda is now talked about in two places:

Installing scientific packages

and

Project Summaries

perhaps one of them should simply be alink to the. other -- probably Project Summaries can ref to Installing scientific packages.

Though I'm not totally on board with that -- while conda was developed for, and widely used by the Scientific computing community -- it's a more universal tool than that so maybe?


📚 Documentation preview 📚: https://python-packaging-user-guide--1581.org.readthedocs.build/en/1581/

@ChrisBarker-NOAA ChrisBarker-NOAA mentioned this pull request Aug 1, 2024
@ncoghlan
Copy link
Member

ncoghlan commented Aug 14, 2024

I think the way you've done it here is a good compromise: enough detail inline for the scientific packages section to make sense, but the larger amount of info in the project description. If a reference were to be added, I'd make it from the scientific section to the project summary (but not at the expense of the inline explanation of the relevance of the tool).

The build failure picked up a genuine structural issue, though: the Anaconda link is duplicated because one of the new paragraphs should be moved up to replace the old intro paragraph outright (the fact the old intro paragraph references Anaconda 5.0 suggests the previous text is at least 7 years old)

Leaving my approval active (since I agree with the gist of the change), but putting some comments in line with a suggestion to fix the build error.

source/key_projects.rst Outdated Show resolved Hide resolved
source/key_projects.rst Outdated Show resolved Hide resolved
source/key_projects.rst Outdated Show resolved Hide resolved
ChrisBarker-NOAA and others added 3 commits August 19, 2024 17:06
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
source/key_projects.rst Outdated Show resolved Hide resolved
@ChrisBarker-NOAA
Copy link
Contributor Author

@sinoroc, @ncoghlan: thanks for the copy-editing!

@ChrisBarker-NOAA
Copy link
Contributor Author

fixed the netlib link ..

@webknjaz
Copy link
Member

@ChrisBarker-NOAA looks like the anaconda website link breaks linkcheck. Could you take a look at addressing that?

@ChrisBarker-NOAA
Copy link
Contributor Author

ChrisBarker-NOAA commented Oct 30, 2024

I'm confused -- this works for me right now:

https://anaconda.org/

?!?!

Maybe a blip at that time -- can it be re-run?

@webknjaz
Copy link
Member

@ChrisBarker-NOAA I restarted it before tagging you and the error was the same, I believe. This likely means that their website rejects various automated non-browser requests. This might be based on HTTP headers, the user agent string or the fact that it originated from the GitHub Actions platform.
I'll trigger it again but I wouldn't hold your breath. We'll likely need to add it to linkcheck_ignore or find a better link.

@webknjaz
Copy link
Member

auto-merge was automatically disabled November 4, 2024 17:33

Head branch was pushed to by a user without write access

@ChrisBarker-NOAA
Copy link
Contributor Author

OK -- added it to linkcheck_ignore and it's passing -- thanks!

@webknjaz webknjaz added this pull request to the merge queue Nov 24, 2024
Merged via the queue into pypa:main with commit 80ba369 Nov 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants