Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a LICENSES directory when writing wheel metadata #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidfritzsche
Copy link

The paths matched by COPYING* and LICENSE* when adding license files
to the dist-info directory are now allowed to be directories
containing the actual license files.

@takluyver
Copy link
Member

Thanks, this seems reasonable. But I'd like to think a bit more about what the limits are on this feature.

  1. This allows for the top level items (LICENSE* or COPYING*) to be files or directories. But if they're directories, it assumes that the second level items are only files. That seems reasonable enough, but do we have any evidence that subdirectories are rare? What does the failure look like if there are subdirectories?
  2. Should the names for directories be more constrained than the names we match for files? I think the wildcard was primarily so we pick up different extensions (.txt or .md or .rst), which doesn't matter so much for directories. Can we get any systematic look at what people call directories containing license files? Especially as the glob matching might not be case sensitive on all platforms, it shouldn't pick up unexpected directories.

I'm not aware of any tools that actually consume license information from wheels or installed packages, nor of any standard for how they should be stored. So if this is to be useful, it might be worth having a broader discussion on e.g. https://discuss.python.org/ or the distutils-sig mailing list.

The paths matched by COPYING* and LICENSE* when adding license files
to the dist-info directory are now allowed to be directories
containing the actual license files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants