Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subcommands #264

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor subcommands #264

wants to merge 5 commits into from

Commits on May 1, 2019

  1. Add "flit info --version" command 

    References pypa#262
    @exhuma
    exhuma committed May 1, 2019
    Configuration menu
    Copy the full SHA
    c1d90d8 View commit details
    Browse the repository at this point in the history

  2. Refactor subcommands 

    This change yanks out each subcommand from `flit/__init__.py` and moves
them to an isolated file in `flit/subcommand`. Additionally,
`flit.subcommand.register` has been implemented to dynamically load
these subcommands and make them available via argparse. See
`flit/subcommand/__init__.py` for details.

This could have been implemented as classes/subclasses which would avoid
import caching and aid testing, but, in my opinion the structure with
modules is simpler.
    @exhuma
    exhuma committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b4fed3d View commit details
    Browse the repository at this point in the history

  3. Fix unit-test for "flit info --version" 

    The "stderr" stream was redirected to stdout which made the test not
representative of the intended use-case and also caused issues on travis
    @exhuma
    exhuma committed May 1, 2019
    Configuration menu
    Copy the full SHA
    eda5758 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue/262-version-number' into refactor-subcommands

    @exhuma
    exhuma committed May 1, 2019
    Configuration menu
    Copy the full SHA
    e8269c4 View commit details
    Browse the repository at this point in the history

  5. Improve coverage on latest changes

    @exhuma
    exhuma committed May 1, 2019
    Configuration menu
    Copy the full SHA
    e7cd73d View commit details
    Browse the repository at this point in the history