Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close requests.Session after use #188

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Close requests.Session after use #188

wants to merge 1 commit into from

Conversation

PabloCastellano
Copy link

@PabloCastellano PabloCastellano commented May 24, 2020 •
edited
Loading

Fixes #187

@PabloCastellano PabloCastellano changed the title Close requests.Session after use (fixes #187) Close requests.Session after use May 24, 2020
frost-nzcr4
frost-nzcr4 reviewed Oct 25, 2021
View reviewed changes
Copy link

@frost-nzcr4 frost-nzcr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the session after each request will slow down your connections but when you really need it, you can access private property of the Client class from the Django view method to close it:

client = Client(...)
client._Client__s.close()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frost-nzcr4 frost-nzcr4 frost-nzcr4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requests.Session is not properly closed
2 participants
@PabloCastellano @frost-nzcr4