CPM: Rust: Check status code before saving contents #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation does not check HTTP status code except those handled internally by reqwest. This patch added an additional check against these invalid status codes by simply comparing with 400, so invalid response payloads are not saved to the disk and user may retry later by re-invoking the update command. Signed-off-by: Yilin Sun <[email protected]>
|
Related to: #162 |
|
Thank you!! |
flit
approved these changes
Dec 22, 2022
mathias-arm
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not check HTTP status code except those handled internally by reqwest. This patch added an additional check against these invalid status codes by simply comparing with 400, so invalid response payloads are not saved to the disk and user may retry later by re-invoking the update command.
Signed-off-by: Yilin Sun [email protected]