Allow arbitrary ON values for CheckBoxes #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously insisted that the ON-values for CheckBoxes are defined as "Yes" in the PDF (the published recommended value). This fix introduces lifts this restriction and supports arbitrary values as ON for check boxes. So a check box turns to OFF if setting its field value to `False` or "Off". It is set to ON if the field value is set to any of 'True`, "Yes" or the respective value coded in the PDF. When checking a check box's value, the return values invariably are either "Off" or the ON-value in the PDF. Which value this is, can be checked via method `on_state()`.
JorjMcKie
force-pushed
the
address-4055
branch
from
05eb4a1 to
00040fa
Compare
julian-smith-artifex-com
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously insisted on that the ON-values for CheckBoxes are defined as "Yes" in the PDF (the published recommended value).
This fix removes this restriction and supports arbitrary ON values.
So a check box can be turned OFF if setting its field value to
Falseor "Off".It can be turned ON if the field value is set to any of
True, "Yes" or the respective value coded in the PDF.When checking a check box value, the return values always are either "Off" or the ON-value in the PDF. Which value represents ON, can be checked via method
Widget.on_state().