Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IRect hashable #3856

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Make IRect hashable #3856

merged 2 commits into from
Nov 17, 2024

Conversation

elohmeier
Copy link
Contributor

Adds the __hash__ method which is already present in Rect.

@elohmeier
Make IRect hashable
d7a2f81 
Signed-off-by: Enno Richter <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@elohmeier
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 10, 2024
@github-actions
@elohmeier has signed the CLA in #3856
334424c
@julian-smith-artifex-com
Copy link
Collaborator

Note that the Test quick failure is not from this patch.

@JorjMcKie JorjMcKie self-requested a review November 17, 2024 07:44
@JorjMcKie JorjMcKie merged commit d84be3b into pymupdf:main Nov 17, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
@elohmeier elohmeier deleted the irect-hashable branch November 18, 2024 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JorjMcKie JorjMcKie JorjMcKie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elohmeier @julian-smith-artifex-com @JorjMcKie