Various #2981
Merged
Various #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all references to Annot.parent to Annot.get_parent().
Instead have added missing flake8 to scripts/gh_release.py:test_packages, so all required packages will already be available, e.g. when tests are run by `scripts/test.py`. This addresses pymupdf#2950 "Shelling out to pip during tests is problematic".
…rom wheel. This is alternative to using `pip install`, which fails for system installs. We also use `sudo` if root is `/`.
…c fns.
These fns are now in the MuPDF API:
fz_copy_pixmap_rect()
fz_pixmap_size()
fz_scale_pixmap()
fz_subsample_pixmap()
fz_write_pixmap_as_jpeg()
pdf_lookup_page_loc()
This broke test_pagedelete.py::test_deletion.
JorjMcKie
approved these changes
Jan 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix couple of issues, also fix for latest mupdf which makes some internal fns public.