Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major code refactor to unify quasi experiment classes #381

Merged
merged 72 commits into from
Aug 22, 2024
Merged

Major code refactor to unify quasi experiment classes #381

merged 72 commits into from
Aug 22, 2024

Commits on Jun 28, 2024

  1. Very initial work on the big refactor

    @drbenvincent
    drbenvincent committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    df1989f View commit details
    Browse the repository at this point in the history

  2. update uml diagram

    @drbenvincent
    drbenvincent committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d36e289 View commit details
    Browse the repository at this point in the history

  3. change from dict to dataclass

    @drbenvincent
    drbenvincent committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0945fc4 View commit details
    Browse the repository at this point in the history

  4. Friday evening progress

    @drbenvincent
    drbenvincent committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d0d3bc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. bayesian anova sorted + made plot methods static methods

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f87577b View commit details
    Browse the repository at this point in the history

  2. regression discontinuity sorted

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e82325d View commit details
    Browse the repository at this point in the history

  3. regression discontinuity sorted + add summary methods

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4ccea2c View commit details
    Browse the repository at this point in the history

  4. rename classes

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    119f749 View commit details
    Browse the repository at this point in the history

  5. add inverse propensity weighting

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    841cca4 View commit details
    Browse the repository at this point in the history

  6. add docstrings back in

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e5a07d9 View commit details
    Browse the repository at this point in the history

  7. make doctests pass

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7b1e600 View commit details
    Browse the repository at this point in the history

  8. make lots of tests pass

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    48cf9b5 View commit details
    Browse the repository at this point in the history

  9. make test pass - Line2D

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5c2b103 View commit details
    Browse the repository at this point in the history

  10. fix import

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b23b373 View commit details
    Browse the repository at this point in the history

  11. add docstrings to make interrogate pre-commit check pass

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0435456 View commit details
    Browse the repository at this point in the history

  12. Update expt_prepostnegd.py

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ac2389d View commit details
    Browse the repository at this point in the history

  13. fix _causal_impact_summary_stat

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c6ae453 View commit details
    Browse the repository at this point in the history

  14. tidy up plotting

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ff5122f View commit details
    Browse the repository at this point in the history

  15. fix score

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    291dc47 View commit details
    Browse the repository at this point in the history

  16. add convert_to_string + fix typo

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4d10175 View commit details
    Browse the repository at this point in the history

  17. ensure fig, ax returned from plot method

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4442d5b View commit details
    Browse the repository at this point in the history

  18. add causal impact arrow back in to DID plot

    @drbenvincent
    drbenvincent committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    3757199 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. zero failing tests

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6c4e43c View commit details
    Browse the repository at this point in the history

  2. add test coverage for plot method to integration tests

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ae7c405 View commit details
    Browse the repository at this point in the history

  3. fix errors in tests + make some tests pass

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a85ccfb View commit details
    Browse the repository at this point in the history

  4. make a test pass

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    00c1290 View commit details
    Browse the repository at this point in the history

  5. fix docstring + add type hint

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5b5ccd2 View commit details
    Browse the repository at this point in the history

  6. make another plot test pass

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c3df3eb View commit details
    Browse the repository at this point in the history

  7. fix plotting issue with some scikit-learn models

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2fb344a View commit details
    Browse the repository at this point in the history

  8. fix problem with GaussianProcessRegressor. Back to ZERO failing tests

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fd74658 View commit details
    Browse the repository at this point in the history

  9. re-run most notebooks

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    41bf080 View commit details
    Browse the repository at this point in the history

  10. fix plotting of control units for synthetic control + add test coverage

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c77de98 View commit details
    Browse the repository at this point in the history

  11. update UML

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ea2b859 View commit details
    Browse the repository at this point in the history

  12. tweaks

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b0b4539 View commit details
    Browse the repository at this point in the history

  13. remove commented code

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b0dc8c6 View commit details
    Browse the repository at this point in the history

  14. pre-commit autoupdate

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0af9bfb View commit details
    Browse the repository at this point in the history

  15. improve manual type checking sections in the experiment modules

    @drbenvincent
    drbenvincent committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    28f3b07 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. add/improve module level docstrings

    @drbenvincent
    drbenvincent committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e84c199 View commit details
    Browse the repository at this point in the history

  2. add missing docstrings back in

    @drbenvincent
    drbenvincent committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b0eabff View commit details
    Browse the repository at this point in the history

  3. fix failing doctest

    @drbenvincent
    drbenvincent committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1b26499 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'main' into refactor

    @juanitorduz
    juanitorduz authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    133ee3b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. change data validation mixins to class methods

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5c07e4d View commit details
    Browse the repository at this point in the history

  2. remove commented imports

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    224ec84 View commit details
    Browse the repository at this point in the history

  3. _input_validation -> input_validation

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    100784f View commit details
    Browse the repository at this point in the history

  4. change all asserts outside of tests into checks which raise exceptions

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d6e058c View commit details
    Browse the repository at this point in the history

  5. experiment submodule

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dab5824 View commit details
    Browse the repository at this point in the history

  6. remove setting attributes to None in ExperimentDesign base class

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4b8141d View commit details
    Browse the repository at this point in the history

  7. plot_ATE -> plot_ate

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    47d4479 View commit details
    Browse the repository at this point in the history

  8. change experiment.py::ExperimentalDesign to base.py::BaseExperiment

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    70e58f8 View commit details
    Browse the repository at this point in the history

  9. remove PlotComponent abstract base class

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c080fa9 View commit details
    Browse the repository at this point in the history

  10. add return type hints for plot methods + fix up test assertions

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f915f77 View commit details
    Browse the repository at this point in the history

  11. Handle deprecation like a grown up

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6822c61 View commit details
    Browse the repository at this point in the history

  12. convert the deprecation wrapper classes into functions

    @drbenvincent
    drbenvincent committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1cdf7c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. move plotting into experiment classes, removing PlotComponent entirely

    @drbenvincent
    drbenvincent committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fbc4c94 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. create new helper function, create_causalpy_compatible_class

    @drbenvincent
    drbenvincent committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    fa640b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. fix typo 

    Co-authored-by: Will Dean <[email protected]>
    @drbenvincent @wd60622
    drbenvincent and wd60622 authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4edc6d5 View commit details
    Browse the repository at this point in the history

  2. Update causalpy/experiments/diff_in_diff.py 

    Co-authored-by: Will Dean <[email protected]>
    @drbenvincent @wd60622
    drbenvincent and wd60622 authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    38b0e68 View commit details
    Browse the repository at this point in the history

  3. remove **kwargs being passed to BaseExperiment.__init__

    @drbenvincent
    drbenvincent committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6a9214b View commit details
    Browse the repository at this point in the history

  4. remove unnecessary kwargs in did experiments

    @drbenvincent
    drbenvincent committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0cf4f46 View commit details
    Browse the repository at this point in the history

  5. update uml

    @drbenvincent
    drbenvincent committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    60cfb2a View commit details
    Browse the repository at this point in the history

  6. remove old API pages

    @drbenvincent
    drbenvincent committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    121fe46 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. better model/experiment compatability

    @drbenvincent
    drbenvincent committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    cc62438 View commit details
    Browse the repository at this point in the history

  2. move IPW integration test to better test file

    @drbenvincent
    drbenvincent committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    644cf6b View commit details
    Browse the repository at this point in the history

  3. add warning to NotImplementedError

    @drbenvincent
    drbenvincent committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dede64a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. convert scikitlearn models behind the scenes

    @drbenvincent
    drbenvincent committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    02dacb2 View commit details
    Browse the repository at this point in the history

  2. fix import in one of the tests

    @drbenvincent
    drbenvincent committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3f9763a View commit details
    Browse the repository at this point in the history

  3. improve deprecation warnings

    @drbenvincent
    drbenvincent committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    01ce582 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. fix typo 

    Co-authored-by: Will Dean <[email protected]>
    @drbenvincent @wd60622
    drbenvincent and wd60622 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6f6fade View commit details
    Browse the repository at this point in the history

  2. update deprecation warnings for the scikit-learn experiment classes

    @drbenvincent
    drbenvincent committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    66f22aa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor

    @drbenvincent
    drbenvincent committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    77b0b2b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. depricated -> deprecated

    @drbenvincent
    drbenvincent committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9bc3d25 View commit details
    Browse the repository at this point in the history

  2. remove redundant sample_kwargs definition in test

    @drbenvincent
    drbenvincent committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e0b0847 View commit details
    Browse the repository at this point in the history