-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User specified number of significant figures for numerical outputs #283
Conversation
drbenvincent
commented
Dec 22, 2023
- Closes User specified number of significant figures for numerical result outputs #282
- Doctests and tests pass locally.
- Docstrings updated to reflect the new output you get.
Pfft. These doctests are brittle. Despite thinking it was a great idea, at the moment they are causing more hassle than catching actual problems. Not sure what you think @jpreszler? |
There are definitely some that are particularly problematic, and will continue to be so without some significant changes. I think the value comes over the long-term, but it will be hard to get there without some improvements. The options I see:
My vote would be to temporarily turn off the tests and replace the examples for at least PrePostFit (flakey), RegressionDiscontinuity (flakey) and the Instrumented Variables (slow) and turn doctests back on. I should be able to work on this soon, perhaps even getting better examples over the next week. |
created #284. For now, I think you can just comment out the doctest call in the CI untill that issue is resolved. |
Note to self: I'll finish and merge this PR after #286 is merged |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 76.50% 76.50%
=======================================
Files 20 20
Lines 1345 1345
=======================================
Hits 1029 1029
Misses 316 316 ☔ View full report in Codecov by Sentry. |
Well, I guess I have to increase test coverage to make codecov pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change request ;) Otherwise LGTM.