Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct direction and pass dx #897

Merged
merged 1 commit into from
Nov 20, 2023
Merged

correct direction and pass dx #897

merged 1 commit into from
Nov 20, 2023

Conversation

samwaseda
Copy link
Member

No description provided.

@samwaseda samwaseda requested a review from pmrv October 27, 2023 10:16
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/correct_qha

Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but as we discussed problem likely not completely fixed.

@samwaseda samwaseda merged commit 560de80 into main Nov 20, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the correct_qha branch November 20, 2023 09:54
@jan-janssen
Copy link
Member

@samwaseda Can we coordinate this with the developments in pyiron/atomistics ? And in particular the recent extension to add the harmonic model as additional calculator in pyiron/atomistics#65 ? @liamhuber and I try to get pyiron ready to replace pyiron_base at some point with pyiron_workflow, that is why I try to move all the physics related features to pyiron/atomistics, so if you could merge your changes with the implementation there, that would be great.

@samwaseda
Copy link
Member Author

@samwaseda Can we coordinate this with the developments in pyiron/atomistics ? And in particular the recent extension to add the harmonic model as additional calculator in pyiron/atomistics#65 ? @liamhuber and I try to get pyiron ready to replace pyiron_base at some point with pyiron_workflow, that is why I try to move all the physics related features to pyiron/atomistics, so if you could merge your changes with the implementation there, that would be great.

Sure, I think it's a good idea. I'll come back to you as soon as this class works again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants