Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: implement pep621 #900

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build: implement pep621 #900

wants to merge 5 commits into from

Conversation

kuwv
Copy link
Contributor

@kuwv kuwv commented Jan 7, 2023

Switch invoke to pep621.

Moved invoke => src for various improvements with setuptools and tox.

Need to update orb to work with pep621. This should work with circleci but untested:

---
parameters:
  config:
    ...
    default: pyproject.toml
steps:
  ...
  - run:
      ...
      command: |
        pip install .[dev]
        ...

@kuwv
Copy link
Contributor Author

kuwv commented Jan 7, 2023

@bitprophet I originally created this PR: #767. But I think this is probably less disruptive and more inline with the current PyPI packaging recommendations.

@kuwv kuwv force-pushed the pep621 branch 2 times, most recently from 63b36bb to dfa8fb7 Compare January 15, 2023 23:34
Copy link

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there also be CI related changes with this?

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@LecrisUT
Copy link

Any links to why the standard src/module_name structure? I didn't see it in PEP621

@kuwv
Copy link
Contributor Author

kuwv commented Mar 15, 2023

Here you go: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/

@LecrisUT
Copy link

Thanks, this makes sense

@LecrisUT
Copy link

LecrisUT commented Mar 15, 2023

Check the Circle-CI. You need to link the cache key to pyproject.toml instead of dev-requirements.txt.

Seems like it needs to be re-written with something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants