-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce devcontainers configuration #564
base: 3.12
Are you sure you want to change the base?
Introduce devcontainers configuration #564
Conversation
d9ba86e
to
e9a0e1e
Compare
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devcontainer config looks good. Left a couple comments on the Makefile changes and the contributing guide.
@gmargaritis πολύ καλή δουλειά, και πιστεύω ότι είναι κάτι που θα εξυπηρετήσει. Εγώ προσωπικά, δεν έχω κάτι να προσθέσω μου φαίνεται μια χαρά, και είναι πολύ καλό που έχουμε 2 τρόπους σεταρίσματος του έργου. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Πιστεύω ότι μπορεί να ενσωματωθεί ως τρόπος.
* Translated distributing/index.po * Update index.po * Update index.po * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: = <=> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: skpanagiotis <[email protected]>
Added devcontainers support
Added the following make commands
make http-serve
: serve the translation preview on a webservermake preview
: builds and serves the translation preview by openingindex.html
on the user's browsermake http-preview
: builds and serves the translation preview a webservermake lint
: runspowrap
andcheck_spellcheck.py
on all.po
files@pygreece/translation I'd vouch to only keep the
http-preview
command for serving the translation preview.