Delete trailing whitespaces on rename and mkdir

[sespivak]

Whitespace at end of filename cause errors while accessing those files
and dirs via WebDAV (e.g. Nautilus, Caja, etc). This patch tries to
avoid creation of such nodes.

[cdujeu]

Hi @sespivak thanks for your PR, welcome on board!
Just to let you know, not ignoring them, but we are in "code-freeze" mode right now (releasing new major version tomorrow), so we'll have to wait for the next version to properly test and merge.
Don't forget to sign the CLA if it's not already done (see pydio.com > community > contribute page).
cheers
charles

[sespivak]

Hi, Charles!
Thank you for your answer. I've sign the CLA already.
It's right to test all the changes carefully. My copy of Pydio already patched, so I can wait any period :).

[7omate]

Hi,
I strongly oppose to this behavior.
Trailing white spaces files must produce an ERROR if they can lead to problems, not be silently renamed.

Silently renaming them makes the Sync impossible.

However trimming the names in JS is ok.

[sespivak]

Hi, @7omate

Silently renaming them makes the Sync impossible.

Maybe. It's must be tested, but problem should be solved.
How do you think, rtrimming whitespaces in filenames packed in zip, can cause any problems?

[7omate]

If you unzip the files locally and on your server you would end up with a different result.

[sespivak]

If you unzip the files locally and on your server you would end up with a different result.

Yes, you are right. But now if I download folder as zip and folder contains any files with unicode chars in their names, they will recoded by iconv to selected codepage, making filenames different from server version. If filenames will be additionally rtrimmed, it's make files usable in windows.

[7omate]

Hi again,
Sorry for the delay.

1. In my opinion if the problem is in WebDAV the fix should be in the webDAV plugin.
2. The other option I think is to allow the creation of nodes but then have an plugin rename all nodes with problematic characters. The plugin should be activated automatically when the workspace has WebDAV active.

How hard would those solutions be?
@cdujeu @sespivak

[sespivak]

Hi, @7omate !

The problem not only in WebDAV, but in handling files and dirs with trailing whitespaces in Windows too.
Those files can be created, deleted, but can't be accessed or renamed. Checked in Windows XP.
So, these files shouldn't be created.

[cdujeu]

@7omate retesting this use case with my Windows 7, I have a sync with jpg file set up. If I rename the file with a trailing space after the jpg extension, it then just... disappear from the local folder on windows!!
Did you do some test on your side? It think that's a real issue here :-)
Tested with client 1.2.8

[cdujeu]

Not fully fixed yet, but at least we fixed an issue with the SQL trigger that would create an invalid change (content instead of path) with mysql when renaming a file with a trailing space.
To be continued...