Add logfire.warning to mirror logging.warning #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
reviewed
Jan 15, 2025
There was a problem hiding this comment.
i think i'd prefer
def warning(...):
...
warn = warningThere was a problem hiding this comment.
Works for me - are you ok without the note that "warn is an alias of warning"?
There was a problem hiding this comment.
I think you can still have a note in the warning docstring
JacobHayes
force-pushed
the
push-rromkturpvyu
branch
from
62f4d55 to
45734fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 138 138
Lines 11040 11044 +4
Branches 1565 1565
=========================================
+ Hits 11040 11044 +4 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see any obvious docs to update - any I should take a look at?
Closes #793