Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code refactoring #19

Merged
merged 6 commits into from
Apr 24, 2024
Merged

feat: code refactoring #19

merged 6 commits into from
Apr 24, 2024

Conversation

InzGIBA
Copy link
Contributor

@InzGIBA InzGIBA commented Apr 23, 2024

Changes:

  • fix typo in docstring and deletion of an unnecessary variable
  • replacing the old string formatting logic with f-string
  • changed the logic of checking for the value of the variable None

@casbin-bot
Copy link

@Nekotoxin please review

@casbin-bot casbin-bot requested a review from Nekotoxin April 23, 2024 19:03
@hsluoyz hsluoyz closed this Apr 24, 2024
@hsluoyz hsluoyz reopened this Apr 24, 2024
@hsluoyz hsluoyz closed this Apr 24, 2024
@hsluoyz hsluoyz reopened this Apr 24, 2024
@hsluoyz hsluoyz merged commit 36a11f5 into pycasbin:master Apr 24, 2024
38 of 41 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
# [1.4.0](v1.3.0...v1.4.0) (2024-04-24)

### Features

* code refactoring ([#19](#19)) ([36a11f5](36a11f5))
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants