feat: add adapter execution functions #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nekotoxin please review |
wu-clan
force-pushed
the
add-adapter-funcs
branch
from
8d83da3 to
4e09d60
Compare
wu-clan
changed the title
wu-clan
commented
Jan 6, 2024
| @@ -98,6 +98,10 @@ async def _delete_policy_lines(self, ptype, rule): | |||
| else: | |||
| await self.client.lrem(self.key, 0, json.dumps(line.dict())) | |||
|
|
|||
| async def _update_policy_line(self, ptype, old_rule, new_rule): | |||
| # TODO | |||
There was a problem hiding this comment.
Hi, @BustDot
Can you help with this?
I'm trying to migrate async-sqlalchemy-adapter to async-redis-adapter, but I'm missing some execution functions. I've added some, but this function is beyond my reach.
|
@wu-clan plz fix conflict:
|
# Conflicts: # setup.py
|
Replaced by: #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.