Speakers list page #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeximenes
commented
May 22, 2017
filipeximenes
commented
- Adds speakers list page to the navbar
- List all speakers (main and additional) related to approved proposals
- Missing tests: https://github.com/pybay/pybay/issues/72
- Needs some work on CSS: https://github.com/pybay/pybay/issues/73
PirosB3
reviewed
May 23, 2017
| result__status='accepted') | ||
| speakers = [] | ||
| for proposal in accepted_proposals: | ||
| speakers += list(proposal.speakers()) |
|
brilliant! I will test today and merge |
|
Excellent! Thank you so much @filipeximenes. @PirosB3, I'll let you do the merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.